Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding BUNDLE_WITHOUT env variable for modules GHAs #67

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Adding BUNDLE_WITHOUT env variable for modules GHAs #67

merged 1 commit into from
Feb 26, 2024

Conversation

rajat-puppet
Copy link
Contributor

@rajat-puppet rajat-puppet commented Nov 22, 2023 •
edited
Loading

Summary

  • Adding BUNDLE_WITHOUT in release-prep so as to avoid installation of cyclic dependencies of gem affecting the REFERENCE.md generation.
  • Added BUNDLE_WITHOUT in other files to keep the modules other GHAs unaffected.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@rajat-puppet rajat-puppet force-pushed the Adding-BUNDLE_WITHOUT-in-release-prep branch from b5bb0ca to da8a73d Compare November 22, 2023 18:00
@rajat-puppet rajat-puppet changed the title Adding BUNDLE_WITHOUT env variable for release-prep workflow Adding BUNDLE_WITHOUT env variable for module GHAs Nov 22, 2023
@rajat-puppet rajat-puppet changed the title Adding BUNDLE_WITHOUT env variable for module GHAs Adding BUNDLE_WITHOUT env variable for modules GHAs Nov 22, 2023
@rajat-puppet rajat-puppet force-pushed the Adding-BUNDLE_WITHOUT-in-release-prep branch from da8a73d to 55a0d42 Compare November 22, 2023 19:09
@rajat-puppet rajat-puppet marked this pull request as ready for review November 22, 2023 19:12
@rajat-puppet rajat-puppet requested a review from a team as a code owner November 22, 2023 19:12
@rajat-puppet
Copy link
Contributor Author

Keeping this PR on hold based on a minor dependency internally.

@mhashizume
Copy link
Contributor

I'm running into an issue with the module release prep workflow that would be addressed by this PR. Are you able to merge this PR, or are there still dependency issues?

@Ramesh7 Ramesh7 force-pushed the Adding-BUNDLE_WITHOUT-in-release-prep branch from 55a0d42 to cb1f4ef Compare February 26, 2024 16:34
@rajat-puppet rajat-puppet requested a review from a team as a code owner February 26, 2024 16:34
@rajat-puppet rajat-puppet merged commit 4e087d4 into main Feb 26, 2024
2 checks passed
@rajat-puppet rajat-puppet deleted the Adding-BUNDLE_WITHOUT-in-release-prep branch February 26, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanbreen28 jordanbreen28 jordanbreen28 approved these changes

@Ramesh7 Ramesh7 Ramesh7 approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajat-puppet @mhashizume @Ramesh7 @jordanbreen28